Skip to content

Fix/memory v2#1450

Merged
qin-ctx merged 2 commits intomainfrom
fix/memory_v2
Apr 14, 2026
Merged

Fix/memory v2#1450
qin-ctx merged 2 commits intomainfrom
fix/memory_v2

Conversation

@chenjw
Copy link
Copy Markdown
Collaborator

@chenjw chenjw commented Apr 14, 2026

Description

修复 #1391 中的几个cr问题

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

chenjw and others added 2 commits April 14, 2026 21:52
@chenjw @claude
fix: remove timestamp filtering that caused archive metadata mismatch
9562048 
- Remove pre_archive_abstracts time filtering in commit, now passes full messages_to_archive to _run_memory_extraction
- Remove the same filtering in get_session_context
- Restore pre_archive_abstracts field with empty array for API backward compatibility
- Remove unused _get_latest_archive_last_msg_time method

The timestamp filter was causing archive metadata (.abstract.md/.overview.md) to describe a subset of messages rather than the actual messages.jsonl content written to disk.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chenjw
update
895597c
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 85
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 Multiple PR themes

Sub-PR theme: Fix memory v2 session handling

Relevant files:

  • openviking/session/session.py
Sub-PR theme: Fix sanitizeUserTextForCapture for compacted messages

Relevant files:

  • examples/openclaw-plugin/text-utils.ts
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx merged commit 283dce7 into main Apr 14, 2026
6 checks passed
@qin-ctx qin-ctx deleted the fix/memory_v2 branch April 14, 2026 14:36
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 14, 2026
qin-ctx pushed a commit that referenced this pull request Apr 15, 2026
@chenjw @qin-ctx
Fix/memory v2 (#1450)
f2ed30d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qin-ctx qin-ctx qin-ctx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

OpenViking project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjw @qin-ctx